linux-kernel - Re: [PATCH] b4: Include git notes when generating patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250130-powerful-versed-carp-ce8ecc@lemur>
Date: Thu, 30 Jan 2025 16:29:09 -0500
From: Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: tools@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] b4: Include git notes when generating patches

On Thu, Jan 30, 2025 at 04:04:53PM -0500, Yazen Ghannam wrote:
> > I'd love to do that, but git-filter-repo currently doesn't do the right thing
> > with notes, so anyone who starts to rely on notes will find that they are
> > easily lost with most common b4 operations. There's a long-standing RFE to
> > support notes with git-filter-repo:
> > 
> > https://github.com/newren/git-filter-repo/issues/22
> > 
> > Until that happens, I really don't want to pretend that we support notes,
> > because this will result in bad experiences for most who try it.
> > 
> 
> Right, I've encountered issues myself. I've found that the 'tip-commit'
> cover letter strategy works, since git-filter-repo will only operate on
> the final commit.

Unfortunately, tip-commit is not going to fix all instances where this is
likely to break. E.g. running 'b4 trailers -u' will also rebase your series
and lose your notes.

> Could we document some tips for this topic? Or just leave it for now?

I'd just leave it for now. Hopefully, we'll eventually get to the point where
notes are supported without any workarounds (though I've been waiting for a
few years now).

-K