linux-kernel - Re: [PATCH v3] riscv: Fix the PAUSE Opcode for MIPS P8700.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250131-3286dd5adf8e5ff083bcbda4@orel>
Date: Fri, 31 Jan 2025 08:20:45 +0100
From: Andrew Jones <ajones@...tanamicro.com>
To: Charlie Jenkins <charlie@...osinc.com>
Cc: Conor Dooley <conor@...nel.org>, Aleksandar Rikalo <arikalo@...il.com>, 
	linux-riscv@...ts.infradead.org, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	Christoph Müllner <christoph.muellner@...ll.eu>, linux-kernel@...r.kernel.org, 
	Djordje Todorovic <djordje.todorovic@...cgroup.com>
Subject: Re: [PATCH v3] riscv: Fix the PAUSE Opcode for MIPS P8700.

On Thu, Jan 30, 2025 at 04:59:16PM -0800, Charlie Jenkins wrote:
> On Fri, Jan 31, 2025 at 12:43:12AM +0000, Conor Dooley wrote:
> > On Thu, Jan 30, 2025 at 02:58:49PM -0800, Charlie Jenkins wrote:
> > > On Wed, Jan 29, 2025 at 04:19:58PM +0000, Conor Dooley wrote:
...
> > > > Why don't you use the same implementation as the !tools
> > > > copy of the header? (I'm not sure why they're different in the first
> > > > place).
> > > 
> > > It is different because the headers in tools are userspace so it doesn't
> > > make sense to have alternatives.
> > 
> > I assume that's an answer to the first part, and not the bit in
> > brackets since the "first place" difference is about using the .4byte
> > versus having an ifdef/else and you're talking about alternatives.
> > That looks to have been some sort of sync issue or oversight in
> > 6da111574baff, no?
> 
> Yeah it was a response to the first part.
> 
> As for the second part, yes it look it was a syncing issue.
>

I just forgot to update the tools copy at the time of 6da111574baff. We
should first sync it (but with s/RISCV_PAUSE/0x100000f/ to avoid the
need to include insn-def.h) before modifying it with this patch.

Thanks,
drew