linux-kernel - Re: [PATCH v2] watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo SE30 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7571180-c643-42e9-b2b8-4da07c9394c1@roeck-us.net>
Date: Fri, 31 Jan 2025 07:44:36 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: dober@...ovo.com, wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo
 SE30 platform

On 1/16/25 10:29, Mark Pearson wrote:
> Watchdog driver implementation for Lenovo SE30 platform.
> 
> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
...
> --- /dev/null
> +++ b/drivers/watchdog/lenovo_se30_wdt.c
...
> +
> +static int lenovo_se30_wdt_set_timeout(struct watchdog_device *wdog,
> +				       unsigned int timeout)
> +{
> +	wdog->timeout = timeout;
> +	return 0;
> +}
> +

This function, as implemented, is unnecessary. See watchdog_set_timeout()
in drivers/watchdog/watchdog_dev.c.

Guenter