linux-kernel - Re: [PATCH v2] watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo SE30 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <c0981f17-1577-4f1e-ad38-919820f30c1b@app.fastmail.com>
Date: Fri, 31 Jan 2025 11:17:41 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Guenter Roeck" <linux@...ck-us.net>
Cc: "David Ober" <dober@...ovo.com>,
 "Wim Van Sebroeck" <wim@...ux-watchdog.org>, linux-watchdog@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo SE30
 platform

Hi Guenter

On Fri, Jan 31, 2025, at 10:44 AM, Guenter Roeck wrote:
> On 1/16/25 10:29, Mark Pearson wrote:
>> Watchdog driver implementation for Lenovo SE30 platform.
>> 
>> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> ...
>> --- /dev/null
>> +++ b/drivers/watchdog/lenovo_se30_wdt.c
> ...
>> +
>> +static int lenovo_se30_wdt_set_timeout(struct watchdog_device *wdog,
>> +				       unsigned int timeout)
>> +{
>> +	wdog->timeout = timeout;
>> +	return 0;
>> +}
>> +
>
> This function, as implemented, is unnecessary. See watchdog_set_timeout()
> in drivers/watchdog/watchdog_dev.c.
>
Ah - good point. I'll remove this.

Thanks
Mark