linux-kernel - Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a769233-8cdf-4bee-ba6a-3b69767b7d43@collabora.com>
Date: Sat, 1 Feb 2025 12:43:03 +0500
From: Muhammad Usama Anjum <Usama.Anjum@...labora.com>
To: Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <kees@...nel.org>
Cc: Usama.Anjum@...labora.com, Andy Lutomirski <luto@...capital.net>,
 Will Drewry <wad@...omium.org>, Shuah Khan <shuah@...nel.org>,
 Jérôme Glisse <jglisse@...hat.com>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, kernel@...labora.com
Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused
 parameters

On 1/10/25 5:12 AM, Andrew Morton wrote:
> On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook <kees@...nel.org> wrote:
> 
>> On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote:
>>> For the all other case, why should we keep argv/argc and mark them unused
>>> as well when they aren't being used?
>>
>> I'm fine either way, but my personal code style instinct is to keep the
>> "standard" main declaration with argc/argv present. But it's mostly
>> aesthetic.
>>
>> And if you think use of kselftest.h isn't universal, then perhaps we can
>> avoid the macro, but it does seem nicer and more "normal" feeling for
>> the rest of kernel development.
>>
> 
> Agreed.  __attribute__((unused)) is a bit of a mouthful and isn't what
> the kernel developer's eye expects to see.  
In the next version, I'll add a macro and use that.

-- 
BR,
Muhammad Usama Anjum