linux-kernel - Re: [PATCH v4 2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <746798a0-1a35-4a3f-aa9b-6edfd724bf10@kernel.org>
Date: Sat, 1 Feb 2025 12:42:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shree Ramamoorthy <s-ramamoorthy@...com>, lgirdwood@...il.com,
 broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, aaro.koskinen@....fi, andreas@...nade.info,
 khilman@...libre.com, rogerq@...nel.org, tony@...mide.com, lee@...nel.org,
 linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: m-leonard@...com, praneeth@...com
Subject: Re: [PATCH v4 2/5] regulator: dt-bindings: Add TI TPS65214 PMIC
 bindings

On 31/01/2025 23:11, Shree Ramamoorthy wrote:
>  
> @@ -98,6 +102,16 @@ required:
>  additionalProperties: false
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ti,tps65214
> +    then:
> +      properties:
> +        regulators:
> +          patternProperties:
> +            "^ldo[3-4]$": false

So now, when you combined these patches, you can easily see that you are
duplicating your other "then:" from patch #1. Just combine these into
enum. Don't duplicate.

Best regards,
Krzysztof