linux-kernel - Re: [PATCH v4 2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4198b469-f874-431f-a2de-b4ffa2975c08@ti.com>
Date: Tue, 4 Feb 2025 13:09:20 -0600
From: Shree Ramamoorthy <s-ramamoorthy@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <aaro.koskinen@....fi>, <andreas@...nade.info>,
        <khilman@...libre.com>, <rogerq@...nel.org>, <tony@...mide.com>,
        <lee@...nel.org>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
CC: <m-leonard@...com>, <praneeth@...com>
Subject: Re: [PATCH v4 2/5] regulator: dt-bindings: Add TI TPS65214 PMIC
 bindings

Hi,

On 2/1/25 5:42 AM, Krzysztof Kozlowski wrote:
> On 31/01/2025 23:11, Shree Ramamoorthy wrote:
>>   
>> @@ -98,6 +102,16 @@ required:
>>   additionalProperties: false
>>   
>>   allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: ti,tps65214
>> +    then:
>> +      properties:
>> +        regulators:
>> +          patternProperties:
>> +            "^ldo[3-4]$": false
> So now, when you combined these patches, you can easily see that you are
> duplicating your other "then:" from patch #1. Just combine these into
> enum. Don't duplicate.
>
> Best regards,
> Krzysztof

Thank you for reviewing! I'll add in this feedback, and send a v5 soon pending any other feedback.


-- 
Best,
Shree Ramamoorthy
PMIC Software Engineer