linux-kernel - Re: [PATCH v5 1/5] dt-bindings: PCI: altera: Add binding for Agilex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c51817d4-a971-4aea-5f24-5c3dc1401db0@linux.intel.com>
Date: Sat, 1 Feb 2025 10:11:39 -0800 (PST)
From: matthew.gerlach@...ux.intel.com
To: Krzysztof Kozlowski <krzk@...nel.org>
cc: lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org, 
    robh@...nel.org, bhelgaas@...gle.com, krzk+dt@...nel.org, 
    conor+dt@...nel.org, dinguyen@...nel.org, joyce.ooi@...el.com, 
    linux-pci@...r.kernel.org, devicetree@...r.kernel.org, 
    linux-kernel@...r.kernel.org, matthew.gerlach@...era.com, 
    peter.colberg@...era.com
Subject: Re: [PATCH v5 1/5] dt-bindings: PCI: altera: Add binding for
 Agilex



On Thu, 30 Jan 2025, Krzysztof Kozlowski wrote:

> On 27/01/2025 18:35, Matthew Gerlach wrote:
>> Add the compatible bindings for the three variants of Agilex
>> PCIe Hard IP.
>>
>> Signed-off-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
>> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>> ---
>> v3:
>>  - Remove accepted patches from patch set.
>> ---
>>  .../devicetree/bindings/pci/altr,pcie-root-port.yaml     | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/altr,pcie-root-port.yaml b/Documentation/devicetree/bindings/pci/altr,pcie-root-port.yaml
>> index 52533fccc134..ca9691ec87d2 100644
>> --- a/Documentation/devicetree/bindings/pci/altr,pcie-root-port.yaml
>> +++ b/Documentation/devicetree/bindings/pci/altr,pcie-root-port.yaml
>> @@ -12,9 +12,18 @@ maintainers:
>>
>>  properties:
>>    compatible:
>> +    description: altr,pcie-root-port-1.0 is used for the Cyclone5
>> +      family of chips. The Stratix10 family of chips is supported
>> +      by altr,pcie-root-port-2.0. The Agilex family of chips has
>> +      three variants of PCIe Hard IP referred to as the f-tile, p-tile,
>> +      and r-tile.
>
>
> Has three in the same time? Or one of three? Your board DTS said you
> have exactly one, so this comment is confusing.

I will clarify this comment to reflect that a particular instantiantion 
will only have one of the tiles.

>
>
> Best regards,
> Krzysztof
>

Thanks for the feedback,
Matthew Gerlach