linux-kernel - Re: [PATCH v3 02/20] iio: imu: st_lsm9ds0: Replace device.h with what is needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250203111949.00002fa7@huawei.com>
Date: Mon, 3 Feb 2025 11:19:49 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Raag Jadav <raag.jadav@...el.com>
CC: <gregkh@...uxfoundation.org>, <rafael@...nel.org>,
	<linus.walleij@...aro.org>, <mika.westerberg@...ux.intel.com>,
	<andriy.shevchenko@...ux.intel.com>, <dmitry.torokhov@...il.com>,
	<lgirdwood@...il.com>, <broonie@...nel.org>, <sre@...nel.org>,
	<jic23@...nel.org>, <przemyslaw.kitszel@...el.com>,
	<linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-input@...r.kernel.org>, <linux-sound@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v3 02/20] iio: imu: st_lsm9ds0: Replace device.h with
 what is needed

On Mon,  3 Feb 2025 13:38:44 +0530
Raag Jadav <raag.jadav@...el.com> wrote:

> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Instead of including a huge device.h with tons of dependencies
> include only what driver actually uses.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
I'm fine with these going whatever route makes sense.

Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 2 +-
>  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> index 0732cfa258c4..8cc071463249 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> @@ -7,7 +7,7 @@
>   * Author: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>   */
>  
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
>  #include <linux/err.h>
>  #include <linux/gfp_types.h>
>  #include <linux/i2c.h>
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> index 43ec57c1e604..806e55f75f65 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> @@ -7,7 +7,7 @@
>   * Author: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>   */
>  
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
>  #include <linux/err.h>
>  #include <linux/gfp_types.h>
>  #include <linux/module.h>