linux-kernel - Re: [PATCH v2 2/3] dt-bindings: firmware: stratix10: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <faeb49a6-4fad-41c4-a4da-7a0c47c89e06@altera.com>
Date: Mon, 3 Feb 2025 16:52:20 +0530
From: Mahesh Rao <mahesh.rao@...era.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Mahesh Rao <mahesh.rao@...el.com>, Rob Herring <robh@...nel.org>
Cc: Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
 Tom Rix <trix@...hat.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
 Wu Hao <hao.wu@...el.com>, Ho Yin <adrian.ho.yin.ng@...era.com>,
 Niravkumar L Rabara <nirav.rabara@...era.com>, linux-fpga@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: firmware: stratix10: Convert to
 json-schema

Hi Krzysztof,

On 03-02-2025 04:45 pm, Krzysztof Kozlowski wrote:
> On 03/02/2025 11:42, Mahesh Rao wrote:
>> OK, will add the change.
>>>> +  memory-region:
>>>> +    maxItems: 1
>>>> +    description:
>>>> +      phandle to a reserved memory region for the service layer driver to
>>>> +      communicate with the secure device manager. For more details see
>>>> +      Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt.
>>> Please read what that file says.
>> reserved-memory is moved to dtschema, shall I change this to the following?
>>
>> memory-region:
>>       maxItems: 1
>>       description:
>>         Phandle to a reserved memory region for the service layer driver to
>>         communicate with the secure device manager.
>>         (See reserved-memory in dtschema project.)
>>
>> Is this what is required?
> Drop:
> "Phandle to a"
> "(See reserved-memory in dtschema project.)"
>
> They are redundant, because this cannot be anything else than phandle
> and there is no need to say where each property is. You don't add such
> statement about clocks, interrupts, reg or compatible, so no need for
> memory-region.
>
> Removal makes the description actually nicely compact and accurate. Just
> how efficient text and code should be.
>
>
> Best regards,
> Krzysztof

OK, thanks for the help. I will make the change.

Best regards

Mahesh Rao