linux-kernel - Re: [PATCH] rust: sync: add wait_interruptible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLggyyP1A=uNxr2iYNKOj0V5rxZRU83TRgs6Ah1uJ=Ee2uA@mail.gmail.com>
Date: Mon, 3 Feb 2025 12:56:05 +0100
From: Alice Ryhl <aliceryhl@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, 
	Waiman Long <longman@...hat.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: sync: add wait_interruptible_freezable

On Mon, Feb 3, 2025 at 12:54 PM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Thu, Jan 30, 2025 at 11:30:44AM +0000, Alice Ryhl wrote:
> > Binder allows you to freeze a process where some of its threads are
> > blocked on the Binder driver. To make this work, we need to pass
> > TASK_FREEZABLE when going to sleep in the appropriate places. Thus, add
> > a new method wait_interruptible_freezable for the condition variable so
> > that sleeps where this is supported can be marked as such.
>
> The constraint on freezable is that you must not hold locks. There is a
> lockdep check for this in the code, but it would probably make sense to
> teach Rust about this constraint as well, hmm?

Unfortunately, I don't think there's any way to enforce this at
compile time, but I'm definitely happy to add this in the
documentation.

Thanks!
Alice