linux-kernel - Re: [PATCH stm32-next v3 0/2] ARM: dts: stm32: lxa-fairytux2: add gen{1,2} boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f28bbc1-1ada-41b2-bff2-5ad549c934a5@foss.st.com>
Date: Mon, 3 Feb 2025 13:00:13 +0100
From: Alexandre TORGUE <alexandre.torgue@...s.st.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>,
        "Rob Herring (Arm)"
	<robh@...nel.org>
CC: <linux-stm32@...md-mailman.stormreply.com>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime
 Coquelin <mcoquelin.stm32@...il.com>,
        <linux-kernel@...r.kernel.org>, <kernel@...gutronix.de>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Leonard Göhrs <l.goehrs@...gutronix.de>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH stm32-next v3 0/2] ARM: dts: stm32: lxa-fairytux2: add
 gen{1,2} boards

Hi

On 1/23/25 17:05, Marc Kleine-Budde wrote:
> On 23.01.2025 09:57:47, Rob Herring (Arm) wrote:
>>
>> On Tue, 21 Jan 2025 12:14:04 +0100, Marc Kleine-Budde wrote:
>>> Hello,
>>>
>>> this series adds support for the Linux Automation GmbH FairyTux2
>>> boards generation 1 and 2.
>>>
>>> The FairyTux2 is a small Linux device based on an Octavo Systems
>>> OSD32MP153c SiP, that occupies just two slots on a DIN rail.
>>>
>>> regards,
>>> Marc
>>>
>>> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
>>> ---
>>> Changes in v3:
>>> - 2/2: fix use generic node names for external GPIO and USB Type-C controller (thanks Krzysztof)
>>> - 2/2: LEDs: replace label by color and function property (thanks Krzysztof)
>>> - 2/2: gen2: sort nodes of i2c1 by address (thanks Krzysztof)
>>> - Link to v2: https://patch.msgid.link/20250120-lxa-fairytux-v2-0-95f4a0eaa44d@pengutronix.de
>>>
>>> Changes in v2:
>>> - 1/2: Added Krzysztof's Acked-by
>>> - 2/2: fix alignment for gpio-line-names (thanks Krzysztof)
>>> - 2/2: only use color:function for LED labels (thanks Krzysztof)
>>> - 2/2: use generic node names for external GPIO and USB Type-C controller
>>> - Link to v1: https://patch.msgid.link/20241210-lxa-fairytux-v1-0-9aea01cdb83e@pengutronix.de
>>>
>>> ---
>>> Leonard Göhrs (2):
>>>        dt-bindings: arm: stm32: add compatible strings for Linux Automation GmbH LXA FairyTux 2
>>>        ARM: dts: stm32: lxa-fairytux2: add Linux Automation GmbH FairyTux 2
>>>
>>>   .../devicetree/bindings/arm/stm32/stm32.yaml       |   2 +
>>>   arch/arm/boot/dts/st/Makefile                      |   2 +
>>>   .../boot/dts/st/stm32mp153c-lxa-fairytux2-gen1.dts | 103 ++++++
>>>   .../boot/dts/st/stm32mp153c-lxa-fairytux2-gen2.dts | 147 ++++++++
>>>   .../arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi | 397 +++++++++++++++++++++
>>
>> My bot found new DTB warnings on the .dts files added or changed in this
>> series.
> 
> This patch doesn't touch the offending file "ste-hrefv60plus-tvk.dtb".
> Might be a new warning, but not due to this patch, could this be a false
> positive?

Can you reproduce ? On my side I can't. As you said the reported error 
has no link with your patch. I'll merge it.

regards
ALex



>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>> are fixed by another series. Ultimately, it is up to the platform
>> maintainer whether these warnings are acceptable or not. No need to reply
>> unless the platform maintainer has comments.
>>
>> If you already ran DT checks and didn't see these error(s), then
>> make sure dt-schema is up to date:
>>
>>    pip3 install dtschema --upgrade
>>
>>
>> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/st/' for 20250121-lxa-fairytux-v3-0-8d42d7d232fb@...gutronix.de:
>>
>> arch/arm/boot/dts/st/ste-hrefv60plus-tvk.dtb: gpio@...fe000: compatible:0: 'stericsson,db8500-gpio' is not one of ['st,nomadik-gpio', 'mobileye,eyeq5-gpio']
>> 	from schema $id: http://devicetree.org/schemas/gpio/st,nomadik-gpio.yaml#
> 
> regards,
> Marc
>