linux-kernel - Re: [PATCH] mmc: slot-gpio: Remove unused mmc_gpio_set_cd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFobzCJTaHV6rXwTr-hhzKgN7fAuiUQXjG20pRmBq5wsgg@mail.gmail.com>
Date: Mon, 3 Feb 2025 15:04:21 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: linux@...blig.org
Cc: linus.walleij@...aro.org, brgl@...ev.pl, linux-mmc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: slot-gpio: Remove unused mmc_gpio_set_cd_isr

On Wed, 29 Jan 2025 at 22:43, <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> mmc_gpio_set_cd_isr() last use was removed in 2018 by
> commit 7838a8ddc80b ("mmc: omap_hsmmc: Kill off cover detection")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/slot-gpio.c  | 12 ------------
>  include/linux/mmc/slot-gpio.h |  1 -
>  2 files changed, 13 deletions(-)
>
> diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/core/slot-gpio.c
> index 12247219e1c2..5fd455816393 100644
> --- a/drivers/mmc/core/slot-gpio.c
> +++ b/drivers/mmc/core/slot-gpio.c
> @@ -159,18 +159,6 @@ int mmc_gpio_set_cd_wake(struct mmc_host *host, bool on)
>  }
>  EXPORT_SYMBOL(mmc_gpio_set_cd_wake);
>
> -/* Register an alternate interrupt service routine for
> - * the card-detect GPIO.
> - */
> -void mmc_gpio_set_cd_isr(struct mmc_host *host, irq_handler_t isr)
> -{
> -       struct mmc_gpio *ctx = host->slot.handler_priv;
> -
> -       WARN_ON(ctx->cd_gpio_isr);
> -       ctx->cd_gpio_isr = isr;
> -}
> -EXPORT_SYMBOL(mmc_gpio_set_cd_isr);
> -
>  /**
>   * mmc_gpiod_request_cd - request a gpio descriptor for card-detection
>   * @host: mmc host
> diff --git a/include/linux/mmc/slot-gpio.h b/include/linux/mmc/slot-gpio.h
> index 274a2767ea49..1ed7b0d1e4f9 100644
> --- a/include/linux/mmc/slot-gpio.h
> +++ b/include/linux/mmc/slot-gpio.h
> @@ -22,7 +22,6 @@ int mmc_gpiod_request_cd(struct mmc_host *host, const char *con_id,
>  int mmc_gpiod_request_ro(struct mmc_host *host, const char *con_id,
>                          unsigned int idx, unsigned int debounce);
>  int mmc_gpiod_set_cd_config(struct mmc_host *host, unsigned long config);
> -void mmc_gpio_set_cd_isr(struct mmc_host *host, irq_handler_t isr);
>  int mmc_gpio_set_cd_wake(struct mmc_host *host, bool on);
>  void mmc_gpiod_request_cd_irq(struct mmc_host *host);
>  bool mmc_can_gpio_cd(struct mmc_host *host);
> --
> 2.48.1
>