linux-kernel - Re: [RFC 1/6] scripts/get_abi.py: make it backward-compatible with Python 3.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r04dei1j.fsf@trenco.lwn.net>
Date: Tue, 04 Feb 2025 10:28:08 -0700
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Linux Doc Mailing
 List <linux-doc@...r.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Mauro Carvalho Chehab
 <mchehab+huawei@...nel.org>, linux-kernel@...r.kernel.org, Akira Yokosawa
 <akiyks@...il.com>
Subject: Re: [RFC 1/6] scripts/get_abi.py: make it backward-compatible with
 Python 3.6

Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:

> Despite being introduced on Python 3.6, the original implementation
> was too limited: it doesn't accept anything but the argument.

The original implementation *of f-strings* ?

> Even on python 3.10.12, support was still limited, as more complex
> operations cause SyntaxError:
>
> 	Exception occurred:
> 	  File ".../linux/Documentation/sphinx/kernel_abi.py", line 48, in <module>
> 	    from get_abi import AbiParser
> 	  File ".../linux/scripts/get_abi.py", line 525
> 	    msg += f"{part}\n{"-" * len(part)}\n\n"
>                        ^
> 	SyntaxError: f-string: expecting '}'
>
> Replace f-strings by normal string concatenation when it doesn't
> work on Python 3.6.
>
> Reported-by: Akira Yokosawa <akiyks@...il.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

So I'm curious ... later in the series, you make 3.9 the minimal version
for the kernel.  Given that, is there value in adding compatibility for
older versions here?

Thanks,

jon