linux-kernel - Re: [RFC 1/6] scripts/get_abi.py: make it backward-compatible with Python 3.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4274a2f8-5ba5-45f3-80c5-2de54c44c06f@gmail.com>
Date: Wed, 5 Feb 2025 11:37:52 +0900
From: Akira Yokosawa <akiyks@...il.com>
To: Jonathan Corbet <corbet@....net>,
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: linux-kernel@...r.kernel.org, Akira Yokosawa <akiyks@...il.com>,
 Linux Doc Mailing List <linux-doc@...r.kernel.org>
Subject: Re: [RFC 1/6] scripts/get_abi.py: make it backward-compatible with
 Python 3.6

Hi,

Jonathan Corbet wrote:
> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
> 
>> Despite being introduced on Python 3.6, the original implementation
>> was too limited: it doesn't accept anything but the argument.
> 
> The original implementation *of f-strings* ?
> 
>> Even on python 3.10.12, support was still limited, as more complex
>> operations cause SyntaxError:
>>
>> 	Exception occurred:
>> 	  File ".../linux/Documentation/sphinx/kernel_abi.py", line 48, in <module>
>> 	    from get_abi import AbiParser
>> 	  File ".../linux/scripts/get_abi.py", line 525
>> 	    msg += f"{part}\n{"-" * len(part)}\n\n"
>>                        ^
>> 	SyntaxError: f-string: expecting '}'
>>
>> Replace f-strings by normal string concatenation when it doesn't
>> work on Python 3.6.
>>
>> Reported-by: Akira Yokosawa <akiyks@...il.com>

You might want to add

Closes: https://lore.kernel.org/2d4d3fd1-5fe2-4d18-9085-73f9ff930c2d@gmail.com/

>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> 
> So I'm curious ... later in the series, you make 3.9 the minimal version
> for the kernel.  Given that, is there value in adding compatibility for
> older versions here?

I think rewording the summary to

  "scripts/get_abi.py: make it backward-compatible with Python <3.11"

would resolve Jon's confusion.

I haven't looked into python3'changelog, but it might be
"... backward-compatible with Python <3.12".
Mauro, which python3 release extended the f-string implementation?

        Thanks, Akira