linux-kernel - Re: [PATCH v7 0/9] DTS updates for system1 BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66e2e5e4-5ce5-442c-ba0f-d12cbe79e868@linux.ibm.com>
Date: Tue, 4 Feb 2025 13:40:01 -0600
From: Ninad Palsule <ninad@...ux.ibm.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>, brgl@...ev.pl,
        linus.walleij@...aro.org, minyard@....org, robh@...nel.org,
        krzk+dt@...nel.org, conor+dt@...nel.org, andrew+netdev@...n.ch,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, openipmi-developer@...ts.sourceforge.net,
        netdev@...r.kernel.org, joel@....id.au, devicetree@...r.kernel.org,
        eajames@...ux.ibm.com, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/9] DTS updates for system1 BMC

Hi Andrew,

Thank you for the review.

>>
>> NINAD PALSULE (6):
> 
> Why is your name all in caps here but not for the binding patches
> below? Can you fix that up?

Fixed in the version 9


>> Ninad Palsule (3):
>>    bindings: ipmi: Add binding for IPMB device intf
> 
> This one needs an ack from Corey if I'm to take it.
> 
>>    dt-bindings: gpio: ast2400-gpio: Add hogs parsing
> 
> This one needs an ack from Linus W or Bartosz if I'm to take it.
> However, it's also causing some grief from Rob's bot:
> 
> https://lore.kernel.org/all/173859694889.2601726.10618336219726193824.robh@kernel.org/
> 
> As the reported nodes should all be hogs the name shouldn't matter
> anywhere else (as far as I'm aware). It would be nice if all the
> warnings were cleaned up before we merged the binding update. That way
> we don't cause everyone else looking at the CHECK_DTBS=y output more
> grief than they already get for the Aspeed devicetrees.
> 
> In order to not get bogged down it might be worth splitting out both
> the IPMB- and GPIO- related patches like you did the FTGMAC100 patch,
> and then I can merge what remains (from a quick look they seem
> relatively uncontroversial).
> 

The warnings are fixed by different patch by Krzysztof. As there are no 
more changes then I will wait for other responses. If I don't get those 
response in couple of days then I will split it.
https://lore.kernel.org/linux-kernel/20250116085947.87241-1-krzysztof.kozlowski@linaro.org/

I am also planning to fix old warnings in the system1 dts in separate patch.


-- 
Thanks & Regards,
Ninad