linux-kernel - Re: [PATCH 3/7] firmware: cs_dsp: Add ability to load multiple coefficient files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3cf81195-80e2-4506-9c16-12998a42984a@opensource.cirrus.com>
Date: Tue, 4 Feb 2025 16:05:46 -0600
From: Fredrik Treven <ftreven@...nsource.cirrus.com>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>
CC: Simon Trimmer <simont@...nsource.cirrus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] firmware: cs_dsp: Add ability to load multiple
 coefficient files

On 2/4/25 04:10, Charles Keepax wrote:
> On Fri, Jan 31, 2025 at 01:56:34PM -0600, Fred Treven wrote:
>> Add cs_dsp_power_up_multiple() which accepts an array of
>> cs_dsp_coeff_desc firmware-filename pairs to load.
>>
>> This enables the user to load more than one tuning file
>> along with the associated firmware.
>>
>> Change cs_dsp_power_up() to make use of the new function
>> with a single coefficient file.
>>
>> Signed-off-by: Fred Treven <ftreven@...nsource.cirrus.com>
>> ---
> 
> Can't say I love loading multiple bin files, feels like a tooling
> issue, but I understand you guys have become fairly dependent on
> it and the fallout isn't too bad in the code so:
> 
> Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> 
> Thanks,
> Charles

I agree, and it is technically possible to combine the bin files into one.
We have strongly suggested doing this to consumers of this driver, but
they are adamantly against it, sighting the fact that they want to
maintain the coefficient files separately on a per-algorithm basis.

Thanks for your understanding,
Fred