linux-kernel - Re: [PATCH 3/7] firmware: cs_dsp: Add ability to load multiple coefficient files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6Hnp7ipO5s1+auC@opensource.cirrus.com>
Date: Tue, 4 Feb 2025 10:10:47 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Fred Treven <ftreven@...nsource.cirrus.com>
CC: Simon Trimmer <simont@...nsource.cirrus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] firmware: cs_dsp: Add ability to load multiple
 coefficient files

On Fri, Jan 31, 2025 at 01:56:34PM -0600, Fred Treven wrote:
> Add cs_dsp_power_up_multiple() which accepts an array of
> cs_dsp_coeff_desc firmware-filename pairs to load.
> 
> This enables the user to load more than one tuning file
> along with the associated firmware.
> 
> Change cs_dsp_power_up() to make use of the new function
> with a single coefficient file.
> 
> Signed-off-by: Fred Treven <ftreven@...nsource.cirrus.com>
> ---

Can't say I love loading multiple bin files, feels like a tooling
issue, but I understand you guys have become fairly dependent on
it and the fallout isn't too bad in the code so:

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles