linux-kernel - Re: [PATCH v2 2/4] arm64: dts: mediatek: add support for MT8370 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f936145-87e9-4a02-9dcb-800659c08a17@collabora.com>
Date: Wed, 5 Feb 2025 15:21:49 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, Sean Wang <sean.wang@...iatek.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 kernel@...labora.com
Subject: Re: [PATCH v2 2/4] arm64: dts: mediatek: add support for MT8370 SoC

Il 15/01/25 11:29, Louis-Alexis Eyraud ha scritto:
> This commit adds the support of the Mediatek MT8370 SoC.
> It is a less powerful variant of MT8390 SoC and their
> main differences are:
> - Arm Cortex-A55 cores number (4 vs 6)
> - Arm Cortex-A78 core speed (2.0 GHz vs 2.2 Ghz)
> - Arm Mali-G57 GPU core number (2 vs 3)
> 
> Like MT8390, MT8370 hardware register maps are identical to MT8188.
> 
> Note:
> In this commit, the mt8370.dtsi does not contain the needed overrides
> to support the Mali GPU (to be done in a future commit).
> 
> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>

Please don't say "this commit does this".

Example:
Add support for the MediaTek MT8370 SoC, a less powerful variant of....

and then [....]

Note:
The devicetree for MT8370 does not currently contain the needed overrides
to support the Mali GPU integrated into this SoC. This is scheduled to be
done with a later change.

Please fix the commit description, after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>