linux-kernel - [PATCH v3] arm64: defconfig: Enable TISCI Interrupt Router and Aggregator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250205062229.3869081-1-vaishnav.a@ti.com>
Date: Wed, 5 Feb 2025 11:52:29 +0530
From: Vaishnav Achath <vaishnav.a@...com>
To: <catalin.marinas@....com>, <will@...nel.org>, <quic_bjorande@...cinc.com>,
        <geert+renesas@...der.be>, <krzysztof.kozlowski@...aro.org>,
        <dmitry.baryshkov@...aro.org>, <arnd@...db.de>,
        <nfraprado@...labora.com>, <ebiggers@...gle.com>, <ardb@...nel.org>,
        <nm@...com>, <vigneshr@...com>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <nfrayer@...libre.com>, <glaroque@...libre.com>, <tglx@...utronix.de>,
        <u-kumar1@...com>, <geert@...ux-m68k.org>, <d-gole@...com>,
        <vaishnav.a@...com>
Subject: [PATCH v3] arm64: defconfig: Enable TISCI Interrupt Router and Aggregator

Enable TISCI Interrupt Router and Interrupt Aggregator drivers.
These IPs are found in all TI K3 SoCs like J721E, AM62X and is required
for core functionality like DMA, GPIO Interrupts which is necessary
during boot, thus make them built-in.

bloat-o-meter summary on vmlinux:
	add/remove: 460/1 grow/shrink: 4/0 up/down: 162483/-8 (162475)
	...
	Total: Before=31615984, After=31778459, chg +0.51%

These configs were previously selected for ARCH_K3 in respective Kconfigs
till commit b8b26ae398c4 ("irqchip/ti-sci-inta : Add module build support")
and commit 2d95ffaecbc2 ("irqchip/ti-sci-intr: Add module build support")
dropped them and few driver configs (TI_K3_UDMA, TI_K3_RINGACC)
dependent on these also got disabled due to this. While re-enabling the
TI_SCI_INT_*_IRQCHIP configs, these configs with missing dependencies
(which are already part of arm64 defconfig) also get re-enabled which
explains the slightly larger size increase from the bloat-o-meter summary.

Fixes: 2d95ffaecbc2 ("irqchip/ti-sci-intr: Add module build support")
Fixes: b8b26ae398c4 ("irqchip/ti-sci-inta : Add module build support")

Signed-off-by: Vaishnav Achath <vaishnav.a@...com>
Tested-by: Dhruva Gole <d-gole@...com>
Reviewed-by: Dhruva Gole <d-gole@...com>
---

V2 : https://lore.kernel.org/all/20250203150801.2399555-1-vaishnav.a@ti.com/
V1 : https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/

V2->V3:
	* Justify in commit message that the patch only restores
	previous behaviour and also the reason for size increase.
	* Collect Dhruva's T-by/R-by.
V1->V2:
	* Add Fixes tag.
	* Add bloat-o-meter summary to commit message.

Previously both of these configs were selected for ARCH_K3 in respective
Kconfigs, but commit b8b26ae398c4 ("irqchip/ti-sci-inta : Add module build support")
and commit 2d95ffaecbc2 ("irqchip/ti-sci-intr: Add module build support")
dropped this recently without adding those back in arm64
defconfig, this causes boot failure in all TI K3 platforms.

Passing bootlog with configs enabled:
https://gist.github.com/vaishnavachath/03d8d3ce0f22219643c2f4d1dd243fd1

 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index cb7da4415599..1f25423de383 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1551,6 +1551,8 @@ CONFIG_PWM_VISCONTI=m
 CONFIG_SL28CPLD_INTC=y
 CONFIG_QCOM_PDC=y
 CONFIG_QCOM_MPM=y
+CONFIG_TI_SCI_INTR_IRQCHIP=y
+CONFIG_TI_SCI_INTA_IRQCHIP=y
 CONFIG_RESET_GPIO=m
 CONFIG_RESET_IMX7=y
 CONFIG_RESET_QCOM_AOSS=y
-- 
2.34.1