linux-kernel - Re: [PATCH 2/2] dt-bindings: dma: at_xdmac: document dma-channels property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250205-dynamic-scorpion-of-climate-9e7b7b@krzk-bin>
Date: Wed, 5 Feb 2025 12:40:17 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dharma Balasubiramani <dharma.b@...rochip.com>
Cc: Ludovic Desroches <ludovic.desroches@...rochip.com>, 
	Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Nicolas Ferre <nicolas.ferre@...rochip.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, 
	Claudiu Beznea <claudiu.beznea@...on.dev>, Charan Pedumuru <charan.pedumuru@...rochip.com>, 
	linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, Tony Han <tony.han@...rochip.com>, 
	Cristian Birsan <cristian.birsan@...rochip.com>
Subject: Re: [PATCH 2/2] dt-bindings: dma: at_xdmac: document dma-channels
 property

On Wed, Feb 05, 2025 at 11:17:03AM +0530, Dharma Balasubiramani wrote:
> Add document for the property "dma-channels" for XDMA controller.

I don't understand why. You are duplicating dma schema.

The same as with other patch - your commit msg is redundant. You say
what we see the diff but you never explain why you are doing these
changes. And in both cases this is really non-obvious.

Apply this feedback to all future contributions - say why you are doing
changes instead of repeating what subject and diff are already saying.

Best regards,
Krzysztof