[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1317d50b-8302-4936-b56c-7a9f5b3970b9@broadcom.com>
Date: Thu, 6 Feb 2025 10:15:50 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Kyle Hendry <kylehendrydev@...il.com>, Andrew Lunn <andrew@...n.ch>,
Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Russell King <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] net: dsa: b53: Enable internal GPHY on BCM63268
Hi Kyle,
On 2/5/25 20:30, Kyle Hendry wrote:
> Some BCM63268 bootloaders do not enable the internal PHYs by default.
> This patch series adds functionality for the switch driver to
> configure the gigabit ethernet PHY.
>
> Signed-off-by: Kyle Hendry <kylehendrydev@...il.com>
So the register address you are manipulating logically belongs in the
GPIO block (GPIO_GPHY_CTRL) which has become quite a bit of a sundry
here. I don't have a strong objection about the approach picked up here
but we will need a Device Tree binding update describing the second (and
optional) register range.
Thanks
--
Florian
Powered by blists - more mailing lists