linux-kernel - Re: [PATCH] serial: mctrl_gpio: Remove unused mctrl_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda=jnUV+N_UCdh_c1mKboaxkK25UPTc0XyrUXNNX_EOug@mail.gmail.com>
Date: Thu, 6 Feb 2025 10:30:00 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: linux@...blig.org
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, brgl@...ev.pl, 
	corbet@....net, linux-serial@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: mctrl_gpio: Remove unused mctrl_gpio_free

On Wed, Jan 29, 2025 at 3:00 AM <linux@...blig.org> wrote:

> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> mctrl_gpio_free() was added in 2014 by
> commit 84130aace839 ("tty/serial: Add GPIOLIB helpers for controlling
> modem lines")
>
> It does have a comment saying:
>   '- * Normally, this function will not be called, as the GPIOs will
>    - * be disposed of by the resource management code.'
>
> indeed, it doesn't seem to have been used since it was added.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Looks correct.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij