linux-kernel - Re: [PATCH 0/3] gpio: bcm-kona: Various GPIO fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY6PbUjEsQFTPjo=YrjyZ6L3gciAmSA16PFKdSVFVrR7w@mail.gmail.com>
Date: Thu, 6 Feb 2025 10:36:31 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Artur Weber <aweber.kernel@...il.com>
Cc: Ray Jui <rjui@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, Scott Branden <sbranden@...adcom.com>, 
	Markus Mayer <markus.mayer@...aro.org>, Tim Kryger <tim.kryger@...aro.org>, 
	Matt Porter <matt.porter@...aro.org>, Markus Mayer <mmayer@...adcom.com>, 
	Christian Daudt <csd@...adcom.com>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 0/3] gpio: bcm-kona: Various GPIO fixups

On Thu, Feb 6, 2025 at 10:34 AM Linus Walleij <linus.walleij@...aro.org> wrote:
> On Thu, Jan 30, 2025 at 6:10 PM Artur Weber <aweber.kernel@...il.com> wrote:
>
> > Fixes two issues that were preventing GPIO from working correctly:
> >
> > - Lock/unlock functions tried to write the wrong bit to the unlock
> >   registers for GPIOs with numbers larger than 32
> >
> > - GPIOs only initialized as IRQs did not unlock the configuration
> >   registers, causing IRQ-related configuration (e.g. setting the IRQ
> >   type) to fail.
> >
> > Also includes a minor fix to add a missing newline to an error message.
> >
> > Tested on a Samsung Galaxy Grand Neo (baffinlite rev02) with a BCM23550
> > (DTS not yet in mainline).
> >
> > Signed-off-by: Artur Weber <aweber.kernel@...il.com>
>
> Looks good to me, do you want to resend the patches picking up the
> Acks or do you want me to apply as-is?

Actually it's Bartosz applying, heh confused this for pinctrl.

But most comments go anyway I think.

Yours,
Linus Walleij