linux-kernel - Re: [PATCH v2 1/2] pipe: introduce struct file_operations pipeanon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250206-gravierend-ungeduldig-d3af18bb6703@brauner>
Date: Thu, 6 Feb 2025 10:49:00 +0100
From: Christian Brauner <brauner@...nel.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, 
	Jeff Layton <jlayton@...nel.org>, David Howells <dhowells@...hat.com>, 
	"Gautham R. Shenoy" <gautham.shenoy@....com>, K Prateek Nayak <kprateek.nayak@....com>, 
	Mateusz Guzik <mjguzik@...il.com>, Neeraj Upadhyay <Neeraj.Upadhyay@....com>, 
	Oliver Sang <oliver.sang@...el.com>, Swapnil Sapkal <swapnil.sapkal@....com>, 
	WangYuli <wangyuli@...ontech.com>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] pipe: introduce struct file_operations
 pipeanon_fops

On Wed, Feb 05, 2025 at 05:16:37PM +0100, Oleg Nesterov wrote:
> On 02/05, Linus Torvalds wrote:
> >
> > On Wed, 5 Feb 2025 at 07:34, Oleg Nesterov <oleg@...hat.com> wrote:
> > >
> > > So that fifos and anonymous pipes could have different f_op methods.
> > > Preparation to simplify the next patch.
> >
> > Looks good, except:
> >
> > > +++ b/fs/internal.h
> > >  extern const struct file_operations pipefifo_fops;
> > > +extern const struct file_operations pipeanon_fops;
> >
> > I think this should just be 'static' to inside fs/pipe.c, no?
> 
> I swear, this is what I did initially ;)
> 
> But then for some reason I thought someone would ask me to export
> pipeanon_fops along with pipefifo_fops for consistency.
> 
> OK, I will wait for other reviews and send V3.

It's fine. Minor things like this I can just fix myself when pulling
this. There's no need to generate more mail traffic for this.