linux-kernel - Re: [v3 2/2] pwm: atcpit100: add Andes PWM driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pfqsycjocrlfsxmty7lm44niuv4723n74hyofpmvuvpandat5v@tvnahmf6zg7m>
Date: Thu, 6 Feb 2025 12:45:34 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Ben Zong-You Xie <ben717@...estech.com>
Cc: krzk@...nel.org, linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, robh@...nel.org, conor+dt@...nel.org
Subject: Re: [v3 2/2] pwm: atcpit100: add Andes PWM driver support

Hello Ben,

On Thu, Feb 06, 2025 at 04:08:58PM +0800, Ben Zong-You Xie wrote:
> Also, I will remove "depends on RISCV" [...]

Krzysztof didn't say so explicitly, but I think he wanted the dependency
to be more restrictive, not less. At least that would be my concern
here.

The rational is: Don't annoy people who work on ARM or x86 with
questions about this driver that they don't need anyhow. If there is no
stricter dependency possible, I'm happy with

	depends on RISCV || COMPILE_TEST

. If however your driver is implemented in an FPGA, adding a dependency
on a set of SoCs that have the known FPGA that provides that device
would be a good idea.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)