linux-kernel - Re: [v3 2/2] pwm: atcpit100: add Andes PWM driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <642f00de-d133-4c59-8dd3-f2ba0107b322@kernel.org>
Date: Sun, 9 Feb 2025 12:16:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ben Zong-You Xie <ben717@...estech.com>, linux-pwm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: ukleinek@...nel.org, robh@...nel.org, conor+dt@...nel.org
Subject: Re: [v3 2/2] pwm: atcpit100: add Andes PWM driver support

On 06/02/2025 09:08, Ben Zong-You Xie wrote:
> On Fri, Jan 24, 2025 at 08:30:48AM +0100, Krzysztof Kozlowski wrote:
>> [EXTERNAL MAIL]
>>
>> On 23/01/2025 20:35, Ben Zong-You Xie wrote:
>>>
>>> +config PWM_ATCPIT100
>>> +     tristate "Andes ATCPIT100 PWM support"
>>> +     depends on OF && HAS_IOMEM
>>> +     depends on RISCV || COMPILE_TEST
>>> +     select REGMAP_MMIO
>>> +     help
>>> +       Generic PWM framework driver for ATCPIT100 on Andes AE350 platform
>>
>>
>> Is AE350 a type of a SoC? Looks like. "depends on RISCV" is wrong -
>> there is nothing RISC-V specific here. You must depend on given
>> SoC/platform.
>>
> 
> Hi Krzysztof,
> 
> AE350 is not a SoC. It's just a reference platform to verify Andes CPUs
> on FPGA. For further information on AE350, please refer to [1].

Then what is the SoC?

> 
> Also, I will remove "depends on RISCV" and fix the coding style problems

No, read the review again and implement it:

"You must depend on given SoC/platform."



Best regards,
Krzysztof