linux-kernel - Re: [PATCH] perf tool_pmu: Add skip check in tool_pmu__event_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWoRhg6eY8OEhKA-TbWb42pOZiiDF1PENuu5dHPMp-dpg@mail.gmail.com>
Date: Fri, 7 Feb 2025 08:52:08 -0800
From: Ian Rogers <irogers@...gle.com>
To: kan.liang@...ux.intel.com
Cc: acme@...nel.org, namhyung@...nel.org, linux-kernel@...r.kernel.org, 
	linux-perf-users@...r.kernel.org, peterz@...radead.org, mingo@...hat.com, 
	thomas.falcon@...el.com
Subject: Re: [PATCH] perf tool_pmu: Add skip check in tool_pmu__event_to_str()

On Fri, Feb 7, 2025 at 7:28 AM <kan.liang@...ux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@...ux.intel.com>
>
> Some topdown related metrics may fail on hybrid machines.
>
>  $perf stat -M tma_frontend_bound
>  Cannot resolve IDs for tma_frontend_bound:
>  cpu_atom@...DOWN_FE_BOUND.ALL@ / (8 * cpu_atom@..._CLK_UNHALTED.CORE@)
>
> In the find_tool_events(), the tool_pmu__event_to_str() is used to
> compare the tool_events. It only checks the event name, no PMU or arch.
> So the tool_events[TOOL_PMU__EVENT_SLOTS] is set to true, because the
> p-core Topdown metrics has "slots" event.
> The tool_events is shared. So when parsing the e-core metrics, the
> "slots" is automatically added.
>
> The "slots" event as a tool event should only be available on arm64. It
> has a different meaning on X86. The tool_pmu__skip_event() intends
> handle the case. Apply it for tool_pmu__event_to_str() as well.
>
> There is a lack of sanity check in the expr__get_id(). Add the check.
>
> Closes: https://lore.kernel.org/lkml/608077bc-4139-4a97-8dc4-7997177d95c4@linux.intel.com/
> Fixes: 069057239a67 ("perf tool_pmu: Move expr literals to tool_pmu")
> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks Kan!

Reviewed-by: Ian Rogers <irogers@...gle.com>

Ian