linux-kernel - Re: [PATCH] perf tool_pmu: Add skip check in tool_pmu__event_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173932434120.264355.5544623069913990027.b4-ty@kernel.org>
Date: Tue, 11 Feb 2025 17:39:01 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: acme@...nel.org, irogers@...gle.com, linux-kernel@...r.kernel.org, 
 linux-perf-users@...r.kernel.org, kan.liang@...ux.intel.com
Cc: peterz@...radead.org, mingo@...hat.com, thomas.falcon@...el.com
Subject: Re: [PATCH] perf tool_pmu: Add skip check in
 tool_pmu__event_to_str()

On Fri, 07 Feb 2025 07:28:44 -0800, kan.liang@...ux.intel.com wrote:
> Some topdown related metrics may fail on hybrid machines.
> 
>  $perf stat -M tma_frontend_bound
>  Cannot resolve IDs for tma_frontend_bound:
>  cpu_atom@...DOWN_FE_BOUND.ALL@ / (8 * cpu_atom@..._CLK_UNHALTED.CORE@)
> 
> In the find_tool_events(), the tool_pmu__event_to_str() is used to
> compare the tool_events. It only checks the event name, no PMU or arch.
> So the tool_events[TOOL_PMU__EVENT_SLOTS] is set to true, because the
> p-core Topdown metrics has "slots" event.
> The tool_events is shared. So when parsing the e-core metrics, the
> "slots" is automatically added.
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung