linux-kernel - Re: [PATCH RFC v2] dt-bindings: mmc: mmc-slot: make compatible property optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <003ffa44-c88a-4234-a54a-50cd1140982a@microchip.com>
Date: Fri, 7 Feb 2025 09:02:25 +0000
From: <Dharma.B@...rochip.com>
To: <neil.armstrong@...aro.org>, <ulf.hansson@...aro.org>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <khilman@...libre.com>,
	<jbrunet@...libre.com>, <martin.blumenstingl@...glemail.com>
CC: <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-amlogic@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC v2] dt-bindings: mmc: mmc-slot: make compatible
 property optional

On 07/02/25 2:25 pm, Neil Armstrong wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
> the content is safe
> 
> On 05/02/2025 04:48, Dharma Balasubiramani wrote:
>> Remove the compatible property from the list of required properties and
>> mark it as optional.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@...rochip.com>
>> ---
>> Changes in v2:
>> - Instead of moving the compatible string to the other binding, just 
>> make it
>>    optional (remove from required list).
>> - Link to v1: https://lore.kernel.org/r/20241219-mmc-slot-v1-1- 
>> dfc747a3d3fb@...rochip.com
>> ---
>>   Documentation/devicetree/bindings/mmc/mmc-slot.yaml | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml b/ 
>> Documentation/devicetree/bindings/mmc/mmc-slot.yaml
>> index 1f0667828063..ca3d0114bfc6 100644
>> --- a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml
>> @@ -29,7 +29,6 @@ properties:
>>       maxItems: 1
>>
>>   required:
>> -  - compatible
>>     - reg
> 
> If you remove it from here then it's still required in Documentation/ 
> devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml
> so please add it.

If moving the compatible to its specific binding isn't appropriate (as 
per Conor),
and if removing it from the required list here doesn’t seem reasonable 
to you,
then adding an unnecessary compatible string in our DTS files doesn’t 
make sense to me.

What could be the solution then?
> 
> Thanks,
> Neil
> 
>>
>>   unevaluatedProperties: false
>>
>> ---
>> base-commit: 40b8e93e17bff4a4e0cc129e04f9fdf5daa5397e
>> change-id: 20241219-mmc-slot-0574889daea3
>>
>> Best regards,
> 


-- 
With Best Regards,
Dharma B.