linux-kernel - Re: [PATCH v2] hid: hid-lg-g15: Use standard multicolor LED API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10q50q4n-6p07-nn4p-n8r9-167o85661p25@xreary.bet>
Date: Fri, 7 Feb 2025 13:51:27 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Kate Hsuan <hpa@...hat.com>
cc: Hans de Goede <hdegoede@...hat.com>, 
    Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hid: hid-lg-g15: Use standard multicolor LED API

On Fri, 31 Jan 2025, Kate Hsuan wrote:

> Replace the custom "color" sysfs attribute with the standard multicolor
> LED API.
> 
> This also removes the code for the custom "color" sysfs attribute,
> the "color" sysfs attribute was never documented so hopefully, it is not
> used by anyone.
> 
> If we get complaints, we can re-add the "color" sysfs attribute as
> a compatibility wrapper setting the subleds intensity.
> 
> Signed-off-by: Kate Hsuan <hpa@...hat.com>
> ---
> Changes in v2:
> 1. The commit message was revised with the reviewer's suggestions.
> 2. The incorrect parameters for container_of() were fixed.
> 3. The brightness values were converted by led_mc_calc_color_components().

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs