linux-kernel - Re: [PATCH RESEND v2 1/4] HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qnpr84r1-78q1-8n61-r705-r64q220p7222@xreary.bet>
Date: Fri, 7 Feb 2025 13:53:24 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Aditya Garg <gargaditya08@...e.com>
cc: "bentiss@...nel.org" <bentiss@...nel.org>, 
    Benjamin Tissoires <benjamin.tissoires@...hat.com>, 
    Thomas Weißschuh <linux@...ssschuh.net>, 
    Thomas Weißschuh <thomas@...ch.de>, 
    Kerem Karabay <kekrby@...il.com>, 
    Orlando Chamberlain <orlandoch.dev@...il.com>, 
    Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
    "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH RESEND v2 1/4] HID: hid-appletb-bl: add driver for the
 backlight of Apple Touch Bars

On Wed, 5 Feb 2025, Aditya Garg wrote:

> > Sorry for being dense, but does that mean that it's either 
> > hid-appletb-bl or hid-apple, but never both to make a good user 
> > experience on those devices?
> > 
> > If so, can you please point out what exactly is the reason?
> > 
> > Either those have different VID/PID combination, and then it can be easily
> > made conditional both in code and in runtime.
> > Are we talking about conflicting VID/PID combinations, some of them
> > needing current hid-apple, and some of them needing (in a mutually
> > exclusive way) hid-appletb-bl?
> > 
> 
> Just to clarify a bit more,
> 
> The touchbar backlight device is 05ac:8102, in all the models with magic 
> backlight, that is, with as well as without touchbar. The MacBook Air 
> 2020 is the only model with this device but not having a touchbar.
> 
> This device is responsible for both the touchbar brightness and the 
> keyboard backlight, the 0th interface being responsible for keyboard 
> backlight on Air and 1st on others.

Ah, wow, ok, then it's indeed really messy. Thanks for the explanation.

-- 
Jiri Kosina
SUSE Labs