linux-kernel - Re: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a799e6fa-5ef7-4e1b-993e-52555a73f2a8@sirena.org.uk>
Date: Fri, 7 Feb 2025 13:32:07 +0000
From: Mark Brown <broonie@...nel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@....com>
Cc: alsa-devel@...a-project.org, venkataprasad.potturu@....com,
	Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
	Syed.SabaKareem@....com, Mario.Limonciello@....com
Subject: Re: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts
 handling for ACP7.0 platform

On Fri, Feb 07, 2025 at 11:58:10AM +0530, Vijendar Mukunda wrote:

> +	if (adata->acp_rev == ACP63_PCI_REV) {
> +	} else  {

Unless I find something major in the rest of the series I'll apply this
but it's much better to write these as case statements, that way if you
get additional types to handle it's easier to extend the code sensibly.
Please update this incrementally.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)