[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <55a89842-35f3-4dcb-a23f-c07f43124861@amd.com>
Date: Fri, 7 Feb 2025 19:32:54 +0530
From: "Mukunda,Vijendar" <vijendar.mukunda@....com>
To: Mark Brown <broonie@...nel.org>
Cc: alsa-devel@...a-project.org, venkataprasad.potturu@....com,
Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
Syed.SabaKareem@....com, Mario.Limonciello@....com
Subject: Re: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts
handling for ACP7.0 platform
On 07/02/25 19:02, Mark Brown wrote:
> On Fri, Feb 07, 2025 at 11:58:10AM +0530, Vijendar Mukunda wrote:
>
>> + if (adata->acp_rev == ACP63_PCI_REV) {
>> + } else {
> Unless I find something major in the rest of the series I'll apply this
> but it's much better to write these as case statements, that way if you
> get additional types to handle it's easier to extend the code sensibly.
> Please update this incrementally.
Will push it as an incremental patch.
Powered by blists - more mailing lists