linux-kernel - Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add NULL check in zynqmp_audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250208142125.GC21843@pendragon.ideasonboard.com>
Date: Sat, 8 Feb 2025 16:21:25 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Charles Han <hanchunchao@...pur.com>
Cc: tomi.valkeinen@...asonboard.com, maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
	simona@...ll.ch, michal.simek@....com, vishal.sagar@....com,
	dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add NULL check in
 zynqmp_audio_init

Hi Charles,

Thank you for the patch.

On Sat, Feb 08, 2025 at 06:03:22PM +0800, Charles Han wrote:
> devm_kasprintf() can return a NULL pointer on failure,but this

s/but/ but/

> returned value in zynqmp_audio_init() is not checked.
> Add NULL check in zynqmp_audio_init(), to handle kernel NULL
> pointer dereference error.
> 
> Fixes: 3ec5c1579305 ("drm: xlnx: zynqmp_dpsub: Add DP audio support")
> Signed-off-by: Charles Han <hanchunchao@...pur.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/xlnx/zynqmp_dp_audio.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c b/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c
> index fa5f0ace6084..f07ff4eb3a6d 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c
> @@ -323,12 +323,16 @@ int zynqmp_audio_init(struct zynqmp_dpsub *dpsub)
>  
>  	audio->dai_name = devm_kasprintf(dev, GFP_KERNEL,
>  					 "%s-dai", dev_name(dev));
> +	if (!audio->dai_name)
> +		return -ENOMEM;
>  
>  	for (unsigned int i = 0; i < ZYNQMP_NUM_PCMS; ++i) {
>  		audio->link_names[i] = devm_kasprintf(dev, GFP_KERNEL,
>  						      "%s-dp-%u", dev_name(dev), i);
>  		audio->pcm_names[i] = devm_kasprintf(dev, GFP_KERNEL,
>  						     "%s-pcm-%u", dev_name(dev), i);
> +		if (!audio->link_names[i] || !audio->pcm_names[i])
> +			return -ENOMEM;
>  	}
>  
>  	audio->base = devm_platform_ioremap_resource_byname(pdev, "aud");

-- 
Regards,

Laurent Pinchart