linux-kernel - Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add NULL checks in zynqmp_audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af94dab5-266f-4b1d-95e1-d11a41ebe3e0@web.de>
Date: Sat, 8 Feb 2025 17:00:44 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Charles Han <hanchunchao@...pur.com>, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, David Airlie <airlied@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Michal Simek <michal.simek@....com>,
 Simona Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Vishal Sagar <vishal.sagar@....com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add NULL checks in
 zynqmp_audio_init()

> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in zynqmp_audio_init() is not checked.

Another wording suggestion:
devm_kasprintf() calls can return null pointers on failure.
But some return values were not checked in zynqmp_audio_init().


> Add NULL check in zynqmp_audio_init(), to handle kernel NULL
> pointer dereference error.

Thus add three checks to prevent null pointer dereferences.

Regards,
Markus