linux-kernel - Re: [PATCH] ARM: dts: qcom: msm8960: Add BAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3nz6k4oqwpcmu4miohcgv2wlhz3x5hluuytvkhe6txzg2njatx@icgiiyolzt5w>
Date: Sun, 9 Feb 2025 00:02:08 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Rudraksha Gupta <guptarud@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Sam Day <me@...cday.com>
Subject: Re: [PATCH] ARM: dts: qcom: msm8960: Add BAM

On Sat, Feb 08, 2025 at 11:21:40AM -0800, Rudraksha Gupta wrote:
> Copy bam nodes from qcom-ipq8064.dtsi and change
> the regulator values to match msm8960.
> 
> Signed-off-by: Rudraksha Gupta <guptarud@...il.com>
> Co-developed-by: Sam Day <me@...cday.com>
> Signed-off-by: Sam Day <me@...cday.com>
> ---
> To: Bjorn Andersson <andersson@...nel.org>
> To: Konrad Dybcio <konradybcio@...nel.org>
> To: Rob Herring <robh@...nel.org>
> To: Krzysztof Kozlowski <krzk+dt@...nel.org>
> To: Conor Dooley <conor+dt@...nel.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> index 865fe7cc39511d7cb9ec5c4b12100404f77e2989..01eed68c8f89b547ff0c173b2ca85a54efa29b7f 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> @@ -275,11 +275,31 @@ rng@...00000 {
>  			clock-names = "core";
>  		};
>  
> +		sdcc3bam: dma-controller@...82000 {
> +			compatible = "qcom,bam-v1.3.0";
> +			reg = <0x12182000 0x2000>;

APQ8064 has 0x8000 here, but I think 0x2000 should be enough.

> +			interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&gcc SDC3_H_CLK>;
> +			clock-names = "bam_clk";
> +			#dma-cells = <1>;
> +			qcom,ee = <0>;
> +		};

Please keep DT nodes sorted on the @reg part. So sdcc3bam goes after
sdcc3 node, sdcc1bam goes after sdcc1.

> +
> +		sdcc1bam: dma-controller@...02000 {
> +			compatible = "qcom,bam-v1.3.0";
> +			reg = <0x12402000 0x2000>;
> +			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&gcc SDC1_H_CLK>;
> +			clock-names = "bam_clk";
> +			#dma-cells = <1>;
> +			qcom,ee = <0>;
> +		};
> +
>  		sdcc3: mmc@...80000 {
>  			compatible = "arm,pl18x", "arm,primecell";
>  			arm,primecell-periphid = <0x00051180>;
>  			status = "disabled";
> -			reg = <0x12180000 0x8000>;
> +			reg = <0x12180000 0x2000>;
>  			interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&gcc SDC3_CLK>, <&gcc SDC3_H_CLK>;
>  			clock-names = "mclk", "apb_pclk";
> @@ -289,13 +309,15 @@ sdcc3: mmc@...80000 {
>  			max-frequency = <192000000>;
>  			no-1-8-v;
>  			vmmc-supply = <&vsdcc_fixed>;
> +			dmas = <&sdcc3bam 2>, <&sdcc3bam 1>;
> +			dma-names = "tx", "rx";
>  		};
>  
>  		sdcc1: mmc@...00000 {
>  			status = "disabled";
>  			compatible = "arm,pl18x", "arm,primecell";
>  			arm,primecell-periphid = <0x00051180>;
> -			reg = <0x12400000 0x8000>;
> +			reg = <0x12400000 0x2000>;
>  			interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
>  			clock-names = "mclk", "apb_pclk";
> @@ -305,6 +327,8 @@ sdcc1: mmc@...00000 {
>  			cap-sd-highspeed;
>  			cap-mmc-highspeed;
>  			vmmc-supply = <&vsdcc_fixed>;
> +			dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
> +			dma-names = "tx", "rx";
>  		};
>  
>  		tcsr: syscon@...00000 {
> 
> ---
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> change-id: 20250208-expressatt-bam-d0ed9863a626
> 
> Best regards,
> -- 
> Rudraksha Gupta <guptarud@...il.com>
> 

-- 
With best wishes
Dmitry