linux-kernel - Re: [PATCH v2] rust: alloc: satisfy `aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=k2Ac0Cj0F+xpmUeGuHjf5wqi54qX1SNzMku6RgP9-Lg@mail.gmail.com>
Date: Sun, 9 Feb 2025 00:50:58 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alejandro Colomar <alx@...nel.org>
Cc: DJ Delorie <dj@...hat.com>, Eric Blake <eblake@...hat.com>, 
	Will Newton <will.newton@...aro.org>, Paul Eggert <eggert@...ucla.edu>, linux-man@...r.kernel.org, 
	Danilo Krummrich <dakr@...nel.org>, Tamir Duberstein <tamird@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rust: alloc: satisfy `aligned_alloc` requirements

On Sun, Feb 9, 2025 at 12:35 AM Alejandro Colomar <alx@...nel.org> wrote:
>
> Your manual page is too old.  :)
>
>         commit 7fd1e0f2be216a5e7f7aef0d03304bdf81bca9e0
>         Author: DJ Delorie <dj@...hat.com>
>         Date:   Mon May 8 20:43:35 2023 -0400
>
>             posix_memalign.3: Update aligned_alloc(3) to match C17

Thanks -- good to know it is fixed! Confirming in the VM where I found
the 2023 glibc change, it does have the man pages is updated there
too, so that is great.

> If the implementation in glibc has changed over time, we should probably
> add a HISTORY section documenting historic behavior.

At the very least, glibc made it stricter in d1417176a35d
("aligned_alloc: conform to C17") -- that is the 2023 change I
referred to the other day. Before that, you could pretty much pass any
alignment/size pair and it would succeed (small values).

Cheers,
Miguel