linux-kernel - Re: [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <505dcbf1-c185-4bc3-9615-041dfd6344e5@csgroup.eu>
Date: Sun, 9 Feb 2025 10:16:35 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Hari Bathini <hbathini@...ux.ibm.com>,
 Sourabh Jain <sourabhjain@...ux.ibm.com>,
 "Ritesh Harjani (IBM)" <ritesh.list@...il.com>,
 "Aneesh Kumar K.V (IBM)" <aneesh.kumar@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Baoquan He <bhe@...hat.com>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] fadump: Use str_yes_no() helper in
 fadump_show_config()

Hi,

Le 09/02/2025 à 09:17, Thorsten Blum a écrit :
> Remove hard-coded strings by using the str_yes_no() helper function.
> 
> Reviewed-by: Sourabh Jain <sourabhjain@...ux.ibm.com>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Any reason for resending ? Your patch is not lost, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=89400

If there is a reason that you don't want to put in the commit message, 
just put it here below under the ---

> ---
>   arch/powerpc/kernel/fadump.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index 4b371c738213..8c531533dd3e 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -289,10 +289,8 @@ static void __init fadump_show_config(void)
>   	if (!fw_dump.fadump_supported)
>   		return;
>   
> -	pr_debug("Fadump enabled    : %s\n",
> -				(fw_dump.fadump_enabled ? "yes" : "no"));
> -	pr_debug("Dump Active       : %s\n",
> -				(fw_dump.dump_active ? "yes" : "no"));
> +	pr_debug("Fadump enabled    : %s\n", str_yes_no(fw_dump.fadump_enabled));
> +	pr_debug("Dump Active       : %s\n", str_yes_no(fw_dump.dump_active));
>   	pr_debug("Dump section sizes:\n");
>   	pr_debug("    CPU state data size: %lx\n", fw_dump.cpu_state_data_size);
>   	pr_debug("    HPTE region size   : %lx\n", fw_dump.hpte_region_size);