linux-kernel - Re: [PATCH 09/14] serial: sh-sci: Introduced function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVD1dLP53V_zOhxpqazDdPDVafJ6iohY8u6WPQrmYH5Sw@mail.gmail.com>
Date: Mon, 10 Feb 2025 15:45:02 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH 09/14] serial: sh-sci: Introduced function pointers

Hi Thierry,

On Wed, 29 Jan 2025 at 18:03, Thierry Bultel
<thierry.bultel.yh@...renesas.com> wrote:
> The aim here is to prepare support for new sci controllers like
> the T2H/RSCI whose registers are too much different for being
> handled in common code.
>
> This named serial controller also has 32 bits register,
> so some return types had to be changed.
>
> The needed generic functions are no longer static, with prototypes
> defined in sh-sci-common.h so that they can be used from specific
> implementation in a separate file, to keep this driver as little
> changed as possible.
>
> For doing so, a set of 'ops' is added to struct sci_port.
>
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@...renesas.com>

Thanks for your patch!

I can't say I am super-enthusiastic about this approach.
The SCI variant in RZ/T2 seems to differ a lot from the already
supported SCI, SCIF, SCIFA, SCIFB, and HSCIF variants. The latter
are very similar, but usually have just more features/registers, and
further differ in a few different register offsets and bit locations.
If you compare the RZ/T2 SCI block diagram with the SH7751 SCI block
diagram (or even the R-Car SCIF block diagram), the most striking
similarity is that both have a baud rate generator that can divide
Pclk by 1, 4, 16, or 64 ;-)
So perhaps you're better off adding a completely new driver?

What do other people think?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds