linux-kernel - Re: [PATCH v3 05/35] x86/bugs: Restructure taa mitigation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+i-1C2g=8ALQ6nazX1P7Cpz7PmSC49yMAFO69EmjhAfDv1rCw@mail.gmail.com>
Date: Mon, 10 Feb 2025 17:24:58 +0100
From: Brendan Jackman <jackmanb@...gle.com>
To: David Kaplan <david.kaplan@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, 
	Peter Zijlstra <peterz@...radead.org>, Josh Poimboeuf <jpoimboe@...nel.org>, 
	Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>, Ingo Molnar <mingo@...hat.com>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	"H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 05/35] x86/bugs: Restructure taa mitigation

On Wed, 8 Jan 2025 at 21:27, David Kaplan <david.kaplan@....com> wrote:
> @@ -400,48 +402,71 @@ static void __init taa_select_mitigation(void)
>                 return;
>         }
>
> -       if (cpu_mitigations_off()) {
> +       if (cpu_mitigations_off())
>                 taa_mitigation = TAA_MITIGATION_OFF;
> -               return;
> -       }
>
>         /*
>          * TAA mitigation via VERW is turned off if both
>          * tsx_async_abort=off and mds=off are specified.
> +        *
> +        * MDS mitigation will be checked in taa_update_mitigation().

What we are actually talking about here is the new
verw_mitigation_enabled(), right? I don't think this block/commentary
adds any clarity any more. Maybe just delete it?