linux-kernel - Re: [RFC PATCH 5/6] debugfs: Manual fixes for incomplete Coccinelle conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210114531.20ea15cf@gandalf.local.home>
Date: Mon, 10 Feb 2025 11:45:31 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: David Reaver <me@...idreaver.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J . Wysocki"
 <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>, Christian Brauner
 <brauner@...nel.org>, Alexander Viro <viro@...iv.linux.org.uk>,
 linux-fsdevel@...r.kernel.org, cocci@...ia.fr, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 5/6] debugfs: Manual fixes for incomplete Coccinelle
 conversions

On Sun,  9 Feb 2025 21:20:25 -0800
David Reaver <me@...idreaver.com> wrote:

> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> @@ -9,6 +9,7 @@
>  #include <linux/file.h>
>  
>  struct intel_gt;
> +#define debugfs_node dentry
>  
>  #define __GT_DEBUGFS_ATTRIBUTE_FOPS(__name)				\
>  static const struct file_operations __name ## _fops = {			\

Why are you adding these defines?

All files should be just including <linux/debugfs.h>

so that they can use either "dentry" or "debugfs_node" while you do he
conversion.

Then the last patch should just modify debugfs and debugfs.h and no other
file should be touched.

I'll comment on the last patch to explain what I was expecting to be done
that should satisfy Al.

-- Steve