linux-kernel - Re: [PATCH 1/8] media: platform: chips-media: wave5: Rename Kconfig parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d657fa70-af35-415d-b0e7-3aaf2fd05276@kernel.org>
Date: Mon, 10 Feb 2025 18:24:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nas Chung <nas.chung@...psnmedia.com>, mchehab@...nel.org,
 hverkuil@...all.nl, sebastian.fricke@...labora.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-imx@....com,
 linux-arm-kernel@...ts.infradead.org, jackson.lee@...psnmedia.com,
 lafley.kim@...psnmedia.com
Subject: Re: [PATCH 1/8] media: platform: chips-media: wave5: Rename Kconfig
 parameter

On 10/02/2025 10:07, Nas Chung wrote:
> The existing Kconfig parameter VIDEO_WAVE_VPU is ambiguous,
> as it does not clearly indicate that it is specific to the Wave5 IP.
> 
> Rename VIDEO_WAVE_VPU to VIDEO_WAVE5_VPU to make it explicit
> that the parameter is specific to the Wave5 IP.
> 
> No functional changes, only the parameter name is updated.


That's unnecessary churn. Old name was fine. Kconfig does not match
hardware 1-to-1 but represents only the driver name (or not even that...).

If you solve any particular problem, then explain it. Otherwise this is
just unnecessarily affecting users and backports.

> 
> Signed-off-by: Nas Chung <nas.chung@...psnmedia.com>
> ---
>  arch/arm64/configs/defconfig                      | 2 +-

That's a SoC patch, don't mix up subsystems.


Best regards,
Krzysztof