linux-kernel - Re: [PATCH 2/8] media: v4l2-common: Add YUV24 format info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210140002.rhhxn3z4l3dbyege@basti-TUXEDO-Book-XA1510>
Date: Mon, 10 Feb 2025 15:00:02 +0100
From: Sebastian Fricke <sebastian.fricke@...labora.com>
To: Nas Chung <nas.chung@...psnmedia.com>
Cc: mchehab@...nel.org, hverkuil@...all.nl, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-imx@....com,
	linux-arm-kernel@...ts.infradead.org, jackson.lee@...psnmedia.com,
	lafley.kim@...psnmedia.com
Subject: Re: [PATCH 2/8] media: v4l2-common: Add YUV24 format info

Hey Nas,

On 10.02.2025 18:07, Nas Chung wrote:
>The YUV24 format is missing an entry in the v4l2_format_info().
>The YUV24 format is the packed YUV 4:4:4 formats with 8 bits
>per component.
>

That means that 0376a51fbe5e1 was incomplete, I think you should add a
fixes tag to this commit, to highlight that you basically complete the
previous commit.

Regards,
Sebastian

>Signed-off-by: Nas Chung <nas.chung@...psnmedia.com>
>---
> drivers/media/v4l2-core/v4l2-common.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
>index 0a2f4f0d0a07..de3636f1cdf1 100644
>--- a/drivers/media/v4l2-core/v4l2-common.c
>+++ b/drivers/media/v4l2-core/v4l2-common.c
>@@ -269,6 +269,7 @@ const struct v4l2_format_info *v4l2_format_info(u32 format)
> 		{ .format = V4L2_PIX_FMT_Y212,    .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 2, .vdiv = 1 },
> 		{ .format = V4L2_PIX_FMT_Y216,    .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 2, .vdiv = 1 },
> 		{ .format = V4L2_PIX_FMT_YUV48_12, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 1, .bpp = { 6, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
>+		{ .format = V4L2_PIX_FMT_YUV24,   .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 1, .bpp = { 3, 0, 0, 0 }, .bpp_div = { 1, 1, 1, 1 }, .hdiv = 1, .vdiv = 1 },
> 		{ .format = V4L2_PIX_FMT_MT2110T, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 2, .comp_planes = 2, .bpp = { 5, 10, 0, 0 }, .bpp_div = { 4, 4, 1, 1 }, .hdiv = 2, .vdiv = 2,
> 		  .block_w = { 16, 8, 0, 0 }, .block_h = { 32, 16, 0, 0 }},
> 		{ .format = V4L2_PIX_FMT_MT2110R, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 2, .comp_planes = 2, .bpp = { 5, 10, 0, 0 }, .bpp_div = { 4, 4, 1, 1 }, .hdiv = 2, .vdiv = 2,
>-- 
>2.31.1
>