linux-kernel - Re: [PATCH V8 5/7] interconnect: qcom: sa8775p: Add dynamic icc node id support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <747868ee-9f6b-4bff-a88b-a91ff52e3f06@quicinc.com>
Date: Mon, 10 Feb 2025 11:42:17 +0530
From: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        Odelu Kukatla <quic_okukatla@...cinc.com>,
        "Mike
 Tipton" <quic_mdtipton@...cinc.com>,
        Jeff Johnson
	<quic_jjohnson@...cinc.com>,
        Andrew Halaney <ahalaney@...hat.com>,
        Sibi
 Sankar <quic_sibis@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V8 5/7] interconnect: qcom: sa8775p: Add dynamic icc node
 id support



On 2/6/2025 6:30 AM, Dmitry Baryshkov wrote:
> On Wed, Feb 05, 2025 at 06:27:41PM +0000, Raviteja Laggyshetty wrote:
>> Discard the static IDs from node data and set the default node ID
>> to -1 to indicate the for dynamic ID allocation.
>> Update the topology to use node pointers for links instead of static
>> IDs, and rearrange the node definitions to avoid undefined references.
> 
> I think it might be better to forward-declare all node entries at the
> top and then keep currently defined nodes in place. Otherwise the diff
> is pretty unreadable.
>

Sure, will upload a new patch with forward declarations.
These forward declarations will be present only for SA8775P and for
upcoming SoCs, topology will be adjusted to avoid the forward declarations.
Please review the other patches in this series, so that I can include
the suggestions in the next patch revision.

Thanks,
Raviteja.

>>
>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
>> ---
>>  drivers/interconnect/qcom/sa8775p.c | 2194 ++++++++++++---------------
>>  1 file changed, 962 insertions(+), 1232 deletions(-)
>>
>