linux-kernel - RE: [PATCH v2 04/10] arm64: dts: imx8mn: Add access-controller references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB845912F48DC37B6BC599313888F22@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Mon, 10 Feb 2025 02:36:48 +0000
From: Peng Fan <peng.fan@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Srinivas
 Kandagatla <srinivas.kandagatla@...aro.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 04/10] arm64: dts: imx8mn: Add access-controller
 references

> Subject: Re: [PATCH v2 04/10] arm64: dts: imx8mn: Add access-
> controller references
> 
> Hi Peng,
> 
> Am Freitag, 7. Februar 2025, 13:02:13 CET schrieb Peng Fan:
> > On Fri, Feb 07, 2025 at 09:36:09AM +0100, Alexander Stein wrote:
> > >Mark ocotp as a access-controller and add references on peripherals
> > >which can be disabled (fused).
> >
> > I am not sure whether gpcv2 changes should be included in this
> > patchset or not. Just add access-controller for fused IP will not work.
> 
> Well, I was able to successfully boot a i.MX8M Nano DualLite.
> 
> > i.MX8M BLK-CTRL/GPC will hang if the related power domain is still
> > touched by kernel. The pgc can't power up/down because clock is
> gated.
> 
> Well, with GPU node disabled, no one should enable the power domain.
> But to be on the safe side I would also add access-controllers to the
> corresponding power domains as well.
> 
> > This comment also apply to i.MX8MM/P.
> 
> Sure. Do you have any information what is actually disabled by those
> fused?
> It seems it's the IP and their power domains. Anything else?

In NXP downstream there is a patch for  drivers/pmdomain/imx/imx8m-blk-ctrl.c

soc: imx8m-blk-ctrl: Support fused modules
    
    For fused module, its pgc can't power up/down and clock is gated.
    Because imx8m-blk-ctrl driver will pm_runtime_get_sync/pm_runtime_put
    all power domains during suspend/resume. So we have to remove the
    pgc and clock of fused module from blk-ctrl DTS node.
    Update the driver to support such case.

But this patch also needs U-Boot to update device tree nodes,
I recalled that U-Boot will remove gpc nodes, but not update blk-ctrl nodes.

Regards,
Peng.
> 
> Best regards,
> Alexander
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld,
> Germany Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2F
> www.tq-
> group.com%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7Ca7392a7
> a9a7d480f69c108dd477447bc%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C0%7C0%7C638745286928288330%7CUnknown%7CTWFpbGZ
> sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW
> 4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=F
> R%2BeuYsheLUO8UY6sB%2FGFpTo2911r9tQDl%2BZFqnDqcY%3D&res
> erved=0
> 
>