linux-kernel - Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2663295.taCxCBeP46@diego>
Date: Mon, 10 Feb 2025 13:06:14 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Diederik de Haas <didi.debian@...ow.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk@...nel.org>
Cc: Dragan Simic <dsimic@...jaro.org>,
 Maximilian Weigand <mweigand@...igand.net>, Marek Kraus <gamiee@...e64.org>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

Am Montag, 10. Februar 2025, 12:06:15 MEZ schrieb Krzysztof Kozlowski:
> On 07/02/2025 12:11, Diederik de Haas wrote:
> > Add the recommended chassis-type root node property so userspace can
> > request the form factor and adjust their behavior accordingly.
> > 
> > Signed-off-by: Diederik de Haas <didi.debian@...ow.org>
> > Link: https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
> 
> Drop link, no need to point to source of every property. You don't do it
> for aliases, compatible, model etc, right?
> 
> With link dropped:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

I've amended the patch [0] by dropping the Link and adding Krzysztof's
Reviewed-by.


Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=aba881f30e0294a58c0cb076918d366e39801185