linux-kernel - Re: [PATCH v5] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <183b2a4e-d8bb-454f-8ac7-f74ca9d56269@kernel.org>
Date: Tue, 11 Feb 2025 13:02:45 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Stuart <stuart.a.hayhurst@...il.com>
Cc: linux-input@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <bentiss@...nel.org>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] HID: corsair-void: Add Corsair Void headset family
 driver

On 11. 02. 25, 12:30, Stuart wrote:
>> And what about having one work for all three (reg, up, unreg) as I
>> suggested. As I wrote, IMO, you would need no lock then. Only flags to
>> see what to do there.
> 
> I wasn't super keen on that because it felt like forcing three otherwise
> separate things into one, but it makes sense if I look at it as corsair_void's
> work function.
> 
> Is there a guarantee that the same work item won't run twice at the same time?

It's a single work, it cannot run twice.

> Do I need to make a work queue for that? I'm also not sure how to pass
> arguments to the work function. I'm sure all of that is answered by some
> documentation somewhere, but I couldn't find it myself when I looked previously.

E.g. set_bit() (one bit per OP) to something like 'unsigned long flags' 
in 'struct corsair_void_drvdata'. But it depends if you want to preserve 
order of actions... (Which was not guaranteed with separate queues 
anyway, so I assume not?)

thanks,
-- 
js
suse labs