linux-kernel - Re: [PATCH v5] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTg27nUpWtXDkkSW1yF6Z1K=erFGPOor0kM4xJ08iwkOZyOQg@mail.gmail.com>
Date: Tue, 11 Feb 2025 12:44:55 +0000
From: Stuart <stuart.a.hayhurst@...il.com>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: linux-input@...r.kernel.org, Jiri Kosina <jikos@...nel.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] HID: corsair-void: Add Corsair Void headset family driver

> It's a single work, it cannot run twice.

Ok, thanks

> E.g. set_bit() (one bit per OP) to something like 'unsigned long flags'
> in 'struct corsair_void_drvdata'. But it depends if you want to preserve
> order of actions... (Which was not guaranteed with separate queues
> anyway, so I assume not?)

Wouldn't using one variable for the flags risk overwriting each other, unless
it was atomic? I might be misunderstanding, I haven't played with the kernel's
work much.

Yeah I wasn't worried about the order, since add and remove can't fire that
close to each other anyway.