linux-kernel - Re: [PATCH v10 10/14] platform/x86: Add alienware-wmi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6uGo2UWit61bD7v@smile.fi.intel.com>
Date: Tue, 11 Feb 2025 19:19:31 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Kurt Borja <kuurtb@...il.com>, platform-driver-x86@...r.kernel.org,
	Armin Wolf <W_Armin@....de>,
	Mario Limonciello <mario.limonciello@....com>,
	Hans de Goede <hdegoede@...hat.com>, Dell.Client.Kernel@...l.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 10/14] platform/x86: Add alienware-wmi.h

On Tue, Feb 11, 2025 at 06:51:03PM +0200, Ilpo Järvinen wrote:
> On Tue, 11 Feb 2025, Andy Shevchenko wrote:
> > On Fri, Feb 07, 2025 at 10:46:06AM -0500, Kurt Borja wrote:
> > > Add a header file for alienware-wmi with shared resources to support the
> > > upcoming file split.

...

> > >  static const struct attribute_group *alienfx_groups[] = {
> > >  	&zone_attribute_group,
> > > -	&hdmi_attribute_group,
> > > -	&amplifier_attribute_group,
> > > -	&deepsleep_attribute_group,
> > > +	WMAX_DEV_GROUPS
> > >  	NULL
> > 
> > I don't like this change as it makes code harder to understand (at one glance
> > you can't answer the question "what are the groups that being listed here?".
> 
> Over having #ifdeffery here, I've no problem whatsoever with it (and in 
> fact I suggested goingthis way). It's pretty much boilerplate anyway 
> having to list them yet in another place.

As I said in the reply to the cover letter subthread this is not my main
concern anyway. Let it be then.

-- 
With Best Regards,
Andy Shevchenko